Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catbuffer/parser] feature: restore catparser single pass mode #28

Merged
merged 3 commits into from Jan 17, 2022
Merged

[catbuffer/parser] feature: restore catparser single pass mode #28

merged 3 commits into from Jan 17, 2022

Conversation

Jaguar0625
Copy link
Contributor

  • remove intermediate yaml output from source control
  • update python generator to use ast models instead of yaml input

@0x6861746366574 0x6861746366574 changed the title feature: restore catparser single pass mode [catbuffer/parser] feature: restore catparser single pass mode Jan 17, 2022
@0x6861746366574 0x6861746366574 added the catbuffer-parser Related to catbuffer-parser. label Jan 17, 2022
gimre-xymcity
gimre-xymcity requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@gimre-xymcity gimre-xymcity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing yml schemas though?

@Jaguar0625 Jaguar0625 force-pushed the catbuffer/parser/one-pass-redux branch from 2121f58 to 3e6f768 Compare January 17, 2022 13:22
gimre-xymcity
gimre-xymcity reviewed Jan 17, 2022
View reviewed changes
sdk/python/generator/AbstractImplMap.py Show resolved Hide resolved
sdk/python/generator/FactoryFormatter.py Show resolved Hide resolved
sdk/python/generator/Generator.py Outdated Show resolved Hide resolved
sdk/python/generator/Generator.py Show resolved Hide resolved
sdk/python/generator/Generator.py Show resolved Hide resolved
sdk/python/generator/Generator.py Outdated Show resolved Hide resolved
gimre-xymcity
gimre-xymcity approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@gimre-xymcity gimre-xymcity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀 🌑

@Jaguar0625
feature(catbuffer/parser): add back one pass support to catparser
9e8fcc8 
problem:

current codegen pipeline requires catparser to output YAML file that is ingested by generator scripts.
there is no enforced consistency among generator script usages.
codegen always requires two different scripts with intermediary files produced.

solution:

simplify codegen pipeline to have catparser load generator plugin and output code directly.
this is similar to the original behavior, except it now uses a nicer AST model.
@Jaguar0625
feature(sdk/python): update python generator to use AST models direct…
df30fce 
…ly instead of intermediate YAML
@Jaguar0625
task(catbuffer/schemas): remove intermediary yaml output files
355f662
@Jaguar0625 Jaguar0625 force-pushed the catbuffer/parser/one-pass-redux branch from 95df93c to 355f662 Compare January 17, 2022 14:28
@Jaguar0625 Jaguar0625 merged commit 355f662 into dev Jan 17, 2022
@Jaguar0625 Jaguar0625 deleted the catbuffer/parser/one-pass-redux branch January 17, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimre-xymcity gimre-xymcity gimre-xymcity approved these changes

Assignees
No one assigned
Labels
catbuffer-parser Related to catbuffer-parser.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jaguar0625 @gimre-xymcity @0x6861746366574