Move llvm_double.h implementation to a cpp file and add more functions #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. +1 |
|
I guess we need to have some tests for |
hyperbolic, inverse hyperbolic, inverse trigonometric, error and gamma functions
isuruf
changed the title
|
@ranjithkumar007, @ShikharJ can you have a look? |
ShikharJ
approved these changes
Apr 7, 2017
|
@isuruf Thanks a lot for adding all of the extra |
|
Thanks for the reviews |
isuruf
added a commit
to isuruf/symengine
that referenced
this pull request
Aug 4, 2018
Move llvm_double.h implementation to a cpp file and add more functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213