Latest gcc Travis checks #727
Conversation
| @@ -90,5 +93,5 @@ if [[ "${WITH_PIRANHA}" == "yes" ]]; then | |||
| git clone https://github.com/bluescarni/piranha; | |||
| cd piranha && mkdir build && cd build; | |||
| cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$our_install_dir -DBUILD_TESTS=no ../ && make -j8 install && cd ../..; | |||
| fi | |||
| fi | |||
There was a problem hiding this comment.
Any reason to add this whitespace?
There was a problem hiding this comment.
No the whitespace is not required.
There was a problem hiding this comment.
In #678 I ignored .sh files of the bin folder . Should I remove that exception and check for .sh files too? That would have prevented this error.
|
It seems to be working. +1 to merge, except the minor comment above. |
| @@ -23,6 +23,9 @@ if [[ "${TRAVIS_OS_NAME}" == "linux" ]] && [[ "${CC}" == "gcc" ]]; then | |||
| if [[ "${WITH_PIRANHA}" == "yes" ]]; then | |||
| export CC=gcc-4.8 | |||
| export CXX=g++-4.8 | |||
| elif [[ "${WITH_LATEST_GCC}" == "yes" ]]; then | |||
| export CC=gcc-5 | |||
There was a problem hiding this comment.
Use spaces here instead of tabs to match the indentation of line 25
|
This seems to be using gcc-5.2, so can you change the commit message to reflect that? |
|
It downloaded as version 5.3 on my machine. Where does it say 5.2? |
|
That's because you are using Ubuntu trusty. For precise, it's gcc-5.2. https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=precise |
|
@isuruf Got it ! Thanx for notifying. Changes done |
CodeMaxx
force-pushed
the
Travis-Latest-GCC
branch
from
c57548b
to
6da503e
Compare
CodeMaxx
force-pushed
the
Travis-Latest-GCC
branch
from
6da503e
to
b9d00ba
Compare
|
@CodeMaxx, thanks for the PR |
|
@isuruf Thanx for merging. |
Travis does an additional compiling with gcc 5.2 and g++ 5.2(latest versions)
#684