New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest gcc Travis checks #727

Merged
merged 3 commits into from Jan 1, 2016

Conversation

Projects
None yet
3 participants
@CodeMaxx
Copy link
Contributor

CodeMaxx commented Dec 31, 2015

Travis does an additional compiling with gcc 5.2 and g++ 5.2(latest versions)
#684

@@ -90,5 +93,5 @@ if [[ "${WITH_PIRANHA}" == "yes" ]]; then
git clone https://github.com/bluescarni/piranha;
cd piranha && mkdir build && cd build;
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$our_install_dir -DBUILD_TESTS=no ../ && make -j8 install && cd ../..;
fi
fi

This comment has been minimized.

@certik

certik Dec 31, 2015

Contributor

Any reason to add this whitespace?

This comment has been minimized.

@CodeMaxx

CodeMaxx Dec 31, 2015

Contributor

No the whitespace is not required.

This comment has been minimized.

@CodeMaxx

CodeMaxx Dec 31, 2015

Contributor

In #678 I ignored .sh files of the bin folder . Should I remove that exception and check for .sh files too? That would have prevented this error.

@certik

This comment has been minimized.

Copy link
Contributor

certik commented Dec 31, 2015

It seems to be working. +1 to merge, except the minor comment above.

@@ -23,6 +23,9 @@ if [[ "${TRAVIS_OS_NAME}" == "linux" ]] && [[ "${CC}" == "gcc" ]]; then
if [[ "${WITH_PIRANHA}" == "yes" ]]; then
export CC=gcc-4.8
export CXX=g++-4.8
elif [[ "${WITH_LATEST_GCC}" == "yes" ]]; then
export CC=gcc-5

This comment has been minimized.

@isuruf

isuruf Dec 31, 2015

Member

Use spaces here instead of tabs to match the indentation of line 25

@isuruf

This comment has been minimized.

Copy link
Member

isuruf commented Dec 31, 2015

This seems to be using gcc-5.2, so can you change the commit message to reflect that?

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Dec 31, 2015

It downloaded as version 5.3 on my machine. Where does it say 5.2?

@isuruf

This comment has been minimized.

Copy link
Member

isuruf commented Dec 31, 2015

That's because you are using Ubuntu trusty. For precise, it's gcc-5.2. https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=precise

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Dec 31, 2015

@isuruf Got it ! Thanx for notifying. Changes done

@CodeMaxx CodeMaxx force-pushed the CodeMaxx:Travis-Latest-GCC branch from c57548b to 6da503e Dec 31, 2015

@CodeMaxx CodeMaxx force-pushed the CodeMaxx:Travis-Latest-GCC branch from 6da503e to b9d00ba Dec 31, 2015

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Jan 1, 2016

isuruf added a commit that referenced this pull request Jan 1, 2016

@isuruf isuruf merged commit 849d5a5 into symengine:master Jan 1, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@isuruf

This comment has been minimized.

Copy link
Member

isuruf commented Jan 1, 2016

@CodeMaxx, thanks for the PR

@isuruf isuruf referenced this pull request Jan 1, 2016

Closed

Test latest gcc in travis #684

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Jan 2, 2016

@isuruf Thanx for merging.

@CodeMaxx CodeMaxx deleted the CodeMaxx:Travis-Latest-GCC branch Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment