Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc parser #823

Merged
merged 3 commits into from
Feb 26, 2016
Merged

Misc parser #823

merged 3 commits into from
Feb 26, 2016

Conversation

srajangarg
Copy link
Contributor

Added some missing functionality to the parser, including multi argument function support. (and also some newly added functions)
Also added some tests to check if errors were being thrown correctly.
Also, the current master has trailing whitespaces, which I removed. Why are they creeping in (repeatedly), and why isn't travis reporting them?

@certik
Copy link
Contributor

certik commented Feb 24, 2016

I think this looks great. Thanks.

I don't know why the whitespace check doesn't work, we need to fix it.

@Sumith1896
Copy link
Contributor

Looks good to me too.

Sumith1896 added a commit that referenced this pull request Feb 26, 2016
@Sumith1896 Sumith1896 merged commit f71dd1b into symengine:master Feb 26, 2016
@Sumith1896
Copy link
Contributor

Thanks @srajangarg
Yes, we'll need to fix the whitespace thing.

@CodeMaxx
Copy link
Contributor

I reviewed the whitespace checking code. The code is correct. I believe this has something to do with the position of the code in test_travis.sh

@Sumith1896
Copy link
Contributor

@CodeMaxx Possibly. Abhinav was trying the same here #827
Do send in a PR in case you fix it.

@CodeMaxx
Copy link
Contributor

@Sumith1896 I tried placing the code in different positions in the file but no success. Could it be a problem with Travis?

@CodeMaxx
Copy link
Contributor

Otherwise I think we should add a python script just like we had before.

@srajangarg srajangarg deleted the misc_parser branch June 6, 2016 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants