Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function symbol CWrappers #982

Merged
merged 5 commits into from Jun 10, 2016
Merged

Function symbol CWrappers #982

merged 5 commits into from Jun 10, 2016

Conversation

rajithv
Copy link
Contributor

@rajithv rajithv commented Jun 9, 2016

Wrappers for the FunctionSymbol class

@rajithv rajithv changed the title [WIP] Function symbol [WIP] Function symbol CWrappers Jun 9, 2016
abinashmeher999
abinashmeher999 reviewed Jun 9, 2016
View reviewed changes
symengine/cwrapper.cpp
@@ -26,6 +26,8 @@ using SymEngine::Basic;
using SymEngine::RCP;
using SymEngine::zero;
using SymEngine::Symbol;
using SymEngine::FunctionSymbol;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line required?

@srajangarg
Copy link
Contributor

srajangarg commented Jun 9, 2016 •
edited

Hey @rajithv, can you follow the workflow as mentioned here especially about the clang-format. Otherwise style changes creep into master, and show up in diffs of other PRs.

Edit: This PR won't have any changes, but I think the last PR required some changes.

@rajithv rajithv changed the title [WIP] Function symbol CWrappers Function symbol CWrappers Jun 10, 2016
@isuruf isuruf merged commit 20afef6 into symengine:master Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rajithv @srajangarg @abinashmeher999 @isuruf