Function symbol CWrappers #982

Merged
merged 5 commits into from Jun 10, 2016

Projects

None yet

4 participants

@rajithv
Contributor
rajithv commented Jun 9, 2016

Wrappers for the FunctionSymbol class

rajithv added some commits Jun 9, 2016
@rajithv rajithv FunctionSymbol Wrappers fccf8d1
@rajithv rajithv FunctionSymbol init working
5b133c5
@rajithv rajithv changed the title from [WIP] Function symbol to [WIP] Function symbol CWrappers Jun 9, 2016
@abinashmeher999 abinashmeher999 commented on an outdated diff Jun 9, 2016
symengine/cwrapper.cpp
@@ -26,6 +26,8 @@ using SymEngine::Basic;
using SymEngine::RCP;
using SymEngine::zero;
using SymEngine::Symbol;
+using SymEngine::FunctionSymbol;
@abinashmeher999
abinashmeher999 Jun 9, 2016 Contributor

Is this line required?

@srajangarg
Contributor
srajangarg commented Jun 9, 2016 edited

Hey @rajithv, can you follow the workflow as mentioned here especially about the clang-format. Otherwise style changes creep into master, and show up in diffs of other PRs.

Edit: This PR won't have any changes, but I think the last PR required some changes.

rajithv added some commits Jun 9, 2016
@rajithv rajithv Tests for FunctionSymbol
1e27490
@rajithv rajithv Fixed comparison error in test for FunctionSymbol 6fcf88e
@rajithv rajithv Remove unnecessary line
b401674
@rajithv rajithv changed the title from [WIP] Function symbol CWrappers to Function symbol CWrappers Jun 10, 2016
@isuruf isuruf merged commit 20afef6 into symengine:master Jun 10, 2016

4 checks passed

codecov/patch 100% of diff hit (target 77.83%)
Details
codecov/project 78.02% (+0.19%) compared to b1854ac
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment