Support non java.util.Date dateCreated / lastUpdated types #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Grails 4, the java 8 java.time classes can be used for dateCreated / lastUpdated columns on entities. This plugin assumes java.util.Date (even for autotimestamping) which breaks the ability to use a class such as java.time.Instant for these fields. This change uses the GORM timestamp provider used to provide this same functionality.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Grails 4, the java 8 java.time classes can be used for dateCreated / lastUpdated columns on entities.
This plugin assumes java.util.Date (even for autotimestamping) which breaks the ability to use a class such as java.time.Instant for these fields.
This change uses the GORM timestamp provider used to provide this same functionality.
A limitation in this implementation is it assumes that dateCreated and lastUpdated are the same data type. I can't think of a scenario where someone would want to use different data types for those though.