Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run benchmark tasks on windows due to incorrect directory creation syntax #101

Closed
mkovelamudi opened this issue May 8, 2024 · 5 comments · Fixed by #103
Closed
Assignees
Labels
bug Something isn't working OS:Windows
Milestone

Comments

@mkovelamudi
Copy link

Unable to run benchmark tasks using "eval-dev-quality evaluate" command on windows due to usage of ":" in the directory creation syntax. Check the attached screenshot of the error.

Steps to reproduce

  1. Install Go, Git
  2. Clone the repository and install application.
  3. Run "eval-dev-quality evaluate --model=openrouter/meta-llama/llama-3-70b-instruct" command.

System Configuration
Windows 10 pro

Findings
I found that in evaluat.go file (line 67), following format is used for directory creation.
command.ResultPath = strings.ReplaceAll(command.ResultPath, "%datetime%", evaluationTimestamp.Format("2006-01-02-15:04:05"))

Usage of ":", I believe is not supported for directory creation in windows.

image

@zimmski zimmski self-assigned this May 8, 2024
@zimmski zimmski added the bug Something isn't working label May 8, 2024
@zimmski zimmski added this to the v0.5.0 milestone May 8, 2024
@zimmski
Copy link
Member

zimmski commented May 8, 2024

Thanks @mkovelamudi for the bug report. We only test on Linux but there should be no reason that this doesn't work on Windows. Let me give it a try for a few minutes and get back to you. I do not have a Windows/MacOS machine, so working on non-Linux thingies takes a bit.

zimmski added a commit that referenced this issue May 8, 2024
@zimmski
Copy link
Member

zimmski commented May 8, 2024

Added the easier OS first: MacOS support #102 which shows that we can port to other OSes. So taking a look now in supporting Windows.

zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
…get rid of unsupported colons for Windows

Part of #101
zimmski added a commit that referenced this issue May 8, 2024
…get rid of unsupported colons for Windows

Part of #101
zimmski added a commit that referenced this issue May 8, 2024
- Windows binaries have the file extension ".exe".
- No executable flag needed, because already executable.

Part of #101
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
…get rid of unsupported colons for Windows

Part of #101
zimmski added a commit that referenced this issue May 8, 2024
- Windows binaries have the file extension ".exe".
- No executable flag needed, because already executable.

Part of #101
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
zimmski added a commit that referenced this issue May 8, 2024
@zimmski
Copy link
Member

zimmski commented May 8, 2024

@mkovelamudi will continue tomorrow. I feared that Windows is more work, and i was right. You can track the progress at #103. Looks like the Symflower cache cannot be loaded for some reason. Need to dig in.

@mkovelamudi
Copy link
Author

@zimmski please take your time. I was just trying out and observed the issue. I just wanted to report it.

@zimmski zimmski linked a pull request May 9, 2024 that will close this issue
zimmski added a commit that referenced this issue May 9, 2024
zimmski added a commit that referenced this issue May 9, 2024
zimmski added a commit that referenced this issue May 9, 2024
zimmski added a commit that referenced this issue May 9, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
zimmski added a commit that referenced this issue May 10, 2024
@zimmski
Copy link
Member

zimmski commented May 10, 2024

@mkovelamudi that was quite a rid of Windows-nonsense to figure out. Please give it a try and let me know how the eval runs on your machine!

@zimmski zimmski mentioned this issue May 16, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OS:Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants