-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run benchmark tasks on windows due to incorrect directory creation syntax #101
Comments
Thanks @mkovelamudi for the bug report. We only test on Linux but there should be no reason that this doesn't work on Windows. Let me give it a try for a few minutes and get back to you. I do not have a Windows/MacOS machine, so working on non-Linux thingies takes a bit. |
Added the easier OS first: MacOS support #102 which shows that we can port to other OSes. So taking a look now in supporting Windows. |
…get rid of unsupported colons for Windows Part of #101
…get rid of unsupported colons for Windows Part of #101
- Windows binaries have the file extension ".exe". - No executable flag needed, because already executable. Part of #101
…get rid of unsupported colons for Windows Part of #101
- Windows binaries have the file extension ".exe". - No executable flag needed, because already executable. Part of #101
@mkovelamudi will continue tomorrow. I feared that Windows is more work, and i was right. You can track the progress at #103. Looks like the Symflower cache cannot be loaded for some reason. Need to dig in. |
@zimmski please take your time. I was just trying out and observed the issue. I just wanted to report it. |
…define where tools live Part of #101
…define where tools live Part of #101
@mkovelamudi that was quite a rid of Windows-nonsense to figure out. Please give it a try and let me know how the eval runs on your machine! |
Unable to run benchmark tasks using "eval-dev-quality evaluate" command on windows due to usage of ":" in the directory creation syntax. Check the attached screenshot of the error.
Steps to reproduce
System Configuration
Windows 10 pro
Findings
I found that in evaluat.go file (line 67), following format is used for directory creation.
command.ResultPath = strings.ReplaceAll(command.ResultPath, "%datetime%", evaluationTimestamp.Format("2006-01-02-15:04:05"))
Usage of ":", I believe is not supported for directory creation in windows.
The text was updated successfully, but these errors were encountered: