Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Git to avoid copying the repository on each model run #114

Merged
merged 2 commits into from
May 22, 2024

Conversation

Munsio
Copy link
Contributor

@Munsio Munsio commented May 14, 2024

No description provided.

@Munsio Munsio requested review from zimmski and bauersimon May 14, 2024 15:12
@Munsio Munsio marked this pull request as draft May 14, 2024 15:17
@Munsio Munsio force-pushed the 113-optimize-fs branch 4 times, most recently from c6f6445 to 879f6f6 Compare May 15, 2024 07:44
evaluate/repository.go Outdated Show resolved Hide resolved
evaluate/repository.go Outdated Show resolved Hide resolved
evaluate/repository.go Show resolved Hide resolved
evaluate/repository_test.go Outdated Show resolved Hide resolved
evaluate/repository.go Outdated Show resolved Hide resolved
evaluate/repository.go Outdated Show resolved Hide resolved
@bauersimon
Copy link
Member

watch out - will rebase

@zimmski
Copy link
Member

zimmski commented May 16, 2024

Will add a workaorund for right now: copying for every generation. Need to have the clean up in right now, and this PR seems not ready to move on.

@zimmski zimmski added the enhancement New feature or request label May 18, 2024
@zimmski zimmski added this to the v0.5.0 milestone May 18, 2024
@Munsio Munsio force-pushed the 113-optimize-fs branch 5 times, most recently from 8d0b84d to 2f86958 Compare May 21, 2024 14:25
@Munsio Munsio requested a review from ruiAzevedo19 May 21, 2024 14:29
@Munsio Munsio marked this pull request as ready for review May 21, 2024 14:39
evaluate/repository.go Show resolved Hide resolved
evaluate/repository.go Outdated Show resolved Hide resolved
evaluate/repository_test.go Outdated Show resolved Hide resolved
@Munsio
Copy link
Contributor Author

Munsio commented May 21, 2024

I don't get it, the review resolving does not work how it, imho, should be. I get an "changes requested" on an outdated commit/code how can that even be possible.

@Munsio Munsio requested a review from ruiAzevedo19 May 21, 2024 15:17
@Munsio Munsio force-pushed the 113-optimize-fs branch 2 times, most recently from bac264a to 3bb18ba Compare May 22, 2024 09:00
We initial copy all repositories and then using git to reset changes made by the models to avoid unnecessary temporary directory copies and removals

Closes #113
@Munsio
Copy link
Contributor Author

Munsio commented May 22, 2024

@ruiAzevedo19 I removed the regex test from windows so we can merge this one. Will do a follow-up PR to find a fix for it.

@ruiAzevedo19 ruiAzevedo19 merged commit 80c5639 into main May 22, 2024
3 checks passed
@ruiAzevedo19 ruiAzevedo19 deleted the 113-optimize-fs branch May 22, 2024 09:43
@bauersimon bauersimon mentioned this pull request Jun 3, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants