Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More "write tests" task cases with more complex logic #124

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

bauersimon
Copy link
Member

No description provided.

@bauersimon bauersimon added the enhancement New feature or request label May 17, 2024
@bauersimon bauersimon added this to the v0.5.0 milestone May 17, 2024
language/java/language.go Outdated Show resolved Hide resolved
@bauersimon
Copy link
Member Author

package com.eval;

class TypeArrayAccess {
    static int typeArrayAccess(int[] x) {
        if (x[0] == 123) {
            return x[0];
        }

        return 3;
    }
}

@bauersimon
Copy link
Member Author

Problem with that file and symflower test is that we automatically error in case the maven command exits with 1.

@bauersimon
Copy link
Member Author

@ruiAzevedo19 please take over this PR and extract all the things that can already be merged (i.e. everything except the newly added examples) into an early merger. Nice, pretty commits 🤩 so we can early merge a bunch of stuff. While you are at it please also cherry-pick the refactor+"add service type check" commits from https://github.com/symflower/eval-dev-quality/pull/121/commits.

@zimmski zimmski force-pushed the cases-with-more-logic branch 2 times, most recently from db93bbd to 61319ef Compare May 20, 2024 12:59
@zimmski zimmski mentioned this pull request May 20, 2024
@zimmski zimmski force-pushed the cases-with-more-logic branch 3 times, most recently from 75f2fc0 to 3861f97 Compare May 24, 2024 08:50
@bauersimon
Copy link
Member Author

rebased onto #148

@bauersimon bauersimon force-pushed the cases-with-more-logic branch 3 times, most recently from 10ab6f6 to 3346f2c Compare May 29, 2024 13:29
Copy link
Contributor

@ahumenberger ahumenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also go through the examples and align variables names, and other things such that the Go and Java code looks as similar as possible.

testdata/golang/light/equilibriumIndices.go Outdated Show resolved Hide resolved
testdata/golang/light/equilibriumIndices.go Outdated Show resolved Hide resolved
testdata/golang/light/jacobiSymbol.go Outdated Show resolved Hide resolved
testdata/golang/light/largestProperDivisor.go Outdated Show resolved Hide resolved
testdata/golang/light/magicSquareOdd.go Outdated Show resolved Hide resolved
testdata/golang/light/collatzCalculator.go Outdated Show resolved Hide resolved
testdata/golang/light/pascalsTriangle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ahumenberger ahumenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the examples once more. Did not review the two other commits yet. Not sure if I have enough context to review them.

testdata/golang/light/equilibriumIndices.go Show resolved Hide resolved
testdata/golang/light/go.mod Show resolved Hide resolved
testdata/golang/light/jacobiSymbol.go Show resolved Hide resolved
testdata/golang/light/largestProperDivisor.go Show resolved Hide resolved
testdata/golang/light/collatzCalculator.go Outdated Show resolved Hide resolved
@ruiAzevedo19 ruiAzevedo19 marked this pull request as ready for review June 4, 2024 10:28
@bauersimon bauersimon merged commit b979c27 into main Jun 4, 2024
3 checks passed
@bauersimon bauersimon deleted the cases-with-more-logic branch June 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants