Append a trailing slash to Elasticsearch URL #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154
@fabpot instead of just always appending the trailing slash I went with something different because Platform.sh relationship definition includes a nil path component (see https://docs.platform.sh/add-services/elasticsearch.html#relationship) and I don't want the CLI to break production of your users that could have implemented a workaround for this bug in production.
But if you prefer we can just always append a trailing slash.