Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated binary #463

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Apr 6, 2024

I committed this file by mistake in my first PR, so maybe it's worth ignoring it

@fabpot
Copy link
Contributor

fabpot commented Apr 8, 2024

I don't think this is useful as this name is not referenced anywhere, so when you compile the binary yourself, you can use any name.

@yguedidi
Copy link
Contributor Author

yguedidi commented Apr 8, 2024

I don't think this is useful as this name is not referenced anywhere, so when you compile the binary yourself, you can use any name.

@fabpot I just run go generate then go build and this the filename I got

@fabpot
Copy link
Contributor

fabpot commented Apr 8, 2024

I don't think this is useful as this name is not referenced anywhere, so when you compile the binary yourself, you can use any name.

@fabpot I just run go generate then go build and this the filename I got

Of course, I never run go build without -o :)

@fabpot fabpot merged commit 6e2ba68 into symfony-cli:main Apr 8, 2024
1 check passed
@yguedidi yguedidi deleted the ignore-generated-binary branch April 8, 2024 14:08
@yguedidi
Copy link
Contributor Author

yguedidi commented Apr 8, 2024

I don't think this is useful as this name is not referenced anywhere, so when you compile the binary yourself, you can use any name.

@fabpot I just run go generate then go build and this the filename I got

Of course, I never run go build without -o :)

Because you're way more experienced in Go, me it was the first time writing Go, not even in tutorials, I'm quite proud even for just few lines :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants