-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement PrependExtensionInterface #48
Comments
The goal would be to be able to replace all of this:
With:
|
Should we change |
to me do we need to split the cmf_menu basepath parameter (and route and so on)? if we inject cmf_core.basepath into the bundles, they would still need to know that they put their stuff under "menu" node (resp route, ...). and if x_basepath is set explicitly the param from cmf_core is ignored. |
But then
But as you say we still need to have something specifying "menu" on top of the base path provided by the core bundle. What if we have 2 parameters, "base_path" and "path". The base path would be optional and would prefix the path if supplied. Having a separate parameter would also enable a listener to automatically set the base path in case of a multi-site setup.
|
yeah that makes sense indeed. can we call the second parameter something else than just |
actually, these settings are sonata specific are they not? |
this would be a multiple PR or just for Core? @lsmith77 |
the idea here is to have one bundle that effort effectively configures multiple other bundles |
@dantleech no its not only sonata. its also for the menu provider to know where to find menus, for route provider to know where to look for routes. content and blocks is more open as they are usually referenced. |
see also http://symfony.com/doc/master/components/dependency_injection/compilation.html#prepending-configuration-passed-to-the-extension
the idea would be to make it optionally possible to configure all the key aspects of the core bundles via the CoreBundle.
this would be a nice to have for 1.0 but not a must have as it should be possible to do this without BC breaks
The text was updated successfully, but these errors were encountered: