Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

rename SeoPresentationInterface::updateSeoPage #264

Open
dbu opened this issue Sep 28, 2015 · 3 comments
Open

rename SeoPresentationInterface::updateSeoPage #264

dbu opened this issue Sep 28, 2015 · 3 comments
Milestone

Comments

@dbu
Copy link
Member

dbu commented Sep 28, 2015

As discussed in https://github.com/symfony-cmf/SeoBundle/pull/263/files#r40062307 this method has a strange name. what we do is add seo information. the method should be called something like updateMetadata... this would be an interface change so we can only do it for 2.0

@dbu dbu added this to the 2.0 milestone Sep 28, 2015
@benglass
Copy link
Member

I probably should have put this comment here but I think use of the word Document is overly specific to PHPCR and this method can work for anything that implements the SeoMetadata interface. Other suggestions:

  • updateSeoMetadataFrom($object) // this one gets my vote
  • updateSeoMetadataFromObject($object)
  • updateSeoMetadataFromContent($content) // content doesnt seem like the right name in this case

We could use SeoInformation instead of SeoMetadata in any of these names

@dbu
Copy link
Member Author

dbu commented Sep 28, 2015

  • updateSeoMetadataFrom($object) // this one gets my vote

if we ever update it from something else, this would be odd. like
updateSeoMetadataFromEntityId or something. then again we can just go
with ...From() and all other cases have an explicit name. this is the
default case.

so +1 on this proposal

@dbu
Copy link
Member Author

dbu commented Sep 29, 2015

@benglass proposed updateMetadata() in #263. i like that one best.

@ElectricMaxxx ElectricMaxxx modified the milestones: 2.1, 2.0 Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants