Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

[Sitemap] Provide default last modification date guesser #292

Open
wouterj opened this issue May 25, 2016 · 7 comments
Open

[Sitemap] Provide default last modification date guesser #292

wouterj opened this issue May 25, 2016 · 7 comments

Comments

@wouterj
Copy link
Member

wouterj commented May 25, 2016

I think this should be introduced by calling a custom method or the like (maybe PHPCR can give us the last mod date already?).

Or maybe make it more generic by having a getSitemapData() method. This method will return an array with sitemap values, which we will set on the UrlInformation.

@ElectricMaxxx
Copy link
Member

ElectricMaxxx commented May 25, 2016 via email

@dbu
Copy link
Member

dbu commented May 25, 2016

http://doctrine-orm.readthedocs.io/projects/doctrine-phpcr-odm/en/latest/cookbook/last-modified.html

@ElectricMaxxx
Copy link
Member

ElectricMaxxx commented May 25, 2016 via email

@dbu
Copy link
Member

dbu commented May 26, 2016

if somebody has time to work on it, it would be nice in 1.3. its no BC break, just an additional guesser.

@ElectricMaxxx
Copy link
Member

ElectricMaxxx commented May 26, 2016 via email

@ElectricMaxxx
Copy link
Member

ElectricMaxxx commented May 26, 2016 via email

@dbu
Copy link
Member

dbu commented May 27, 2016

in FOSHttpCache, we have no doctrine integrations. we don't have a guesser architecture there. the problem doing that would be to know which object to use. see also FriendsOfSymfony/FOSHttpCacheBundle#184 for a lot of discussion about content object integration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants