Skip to content

Commit

Permalink
Merge branch '2.3' into 2.6
Browse files Browse the repository at this point in the history
* 2.3:
  Changed visibility of setUp() and tearDown to protected
  fixed XSS in the exception handler
  Php Inspections (EA Extended) - static code analysis includes:
  [2.3] Remove most refs uses
  Test with local components instead of waiting for the subtree-splitter when possible

Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
	src/Symfony/Component/Config/Util/XmlUtils.php
	src/Symfony/Component/Console/Helper/ProgressHelper.php
	src/Symfony/Component/Debug/ExceptionHandler.php
	src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
	src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
	src/Symfony/Component/OptionsResolver/Options.php
	src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php
	src/Symfony/Component/Yaml/Inline.php
  • Loading branch information
nicolas-grekas committed Mar 12, 2015
2 parents d38b4c5 + ee87a3f commit 84aef45
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion File/UploadedFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public static function getMaxFilesize()
} elseif (0 === strpos($max, '0')) {
$max = intval($max, 8);
} else {
$max = intval($max);
$max = (int) $max;
}

switch (substr($iniMax, -1)) {
Expand Down
2 changes: 1 addition & 1 deletion Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ public function getPort()
}

if (false !== $pos) {
return intval(substr($host, $pos + 1));
return (int) substr($host, $pos + 1);
}

return 'https' === $this->getScheme() ? 443 : 80;
Expand Down
2 changes: 1 addition & 1 deletion Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ public static function closeOutputBuffers($targetLevel, $flush)
protected function ensureIEOverSSLCompatibility(Request $request)
{
if (false !== stripos($this->headers->get('Content-Disposition'), 'attachment') && preg_match('/MSIE (.*?);/i', $request->server->get('HTTP_USER_AGENT'), $match) == 1 && true === $request->isSecure()) {
if (intval(preg_replace("/(MSIE )(.*?);/", "$2", $match[0])) < 9) {
if ((int) preg_replace("/(MSIE )(.*?);/", "$2", $match[0]) < 9) {
$this->headers->remove('Cache-Control');
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Session/Flash/AutoExpireFlashBagTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected function setUp()
$this->bag->initialize($this->array);
}

public function tearDown()
protected function tearDown()
{
$this->bag = null;
parent::tearDown();
Expand Down
2 changes: 1 addition & 1 deletion Tests/Session/Flash/FlashBagTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected function setUp()
$this->bag->initialize($this->array);
}

public function tearDown()
protected function tearDown()
{
$this->bag = null;
parent::tearDown();
Expand Down

0 comments on commit 84aef45

Please sign in to comment.