This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Made the swiftmailer.mailer service public and made the command use it instead of the mailer alias.
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it instead of the `mailer` alias.
|
The 2.0 branch of the bundle is a subtree split of the code available in the main symfny repo, as SwitftmailerBundle was developed inside symfony for 2.0. So the PR should be done on symfony, not here |
|
@stof, are you sure about that? I see commits in the 2.0 branch of this bundle that don't exist in the symfony 2.0 branch. |
|
in the 2.0 branch of this bundle ? |
|
Yes. |
|
which one ? I only see 3 commits in the 2.0 branch that are newer than January: the commit of the previous PR, the merge commit of the PR and the revert: https://github.com/symfony/SwiftmailerBundle/commits/2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixed version of the #25 PR. I've made the service public so that there is no need to use the alias.