New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1666] RFC: add support for optional custom error message for Configuration Validation Errors #2

Closed

cordoval wants to merge 1 commit into symfony:master from cordoval:feature/addSupportForOptionalCustomErrorMessageForConfigurationValidationErrors

Contributor

cordoval commented Jul 28, 2012

RFC:

Basically this is the start, but i wanted to ask which one of these options is better:

extend/override the base Exception class to include the custom error message
this requires a modification of the throw specific expection passing Exception($this) meaning it is getting
the current node or the node from which the exception is being thrown
propagate the changes in every class that throws exception similar than this PR
this would require changes in every particular class

Please vote whether 1 or 2 is more fit

Thanks to all symfony2 community :D


          [#1666] RFC: add support for optional custom error message for Config…

d494d6a

…uration validation errors

cordoval closed this

Contributor Author

cordoval commented Jul 28, 2012

already PRed the main symfony/symfony sorry :D

symfony/symfony#5094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment