[Question] Don't delete files that have been modified?

[javiereguiluz]

This Flex behaviour is what I expect

1. composer req cli -> creates ./bin/console
2. Don't change ./bin/console contents
3. composer rem cli -> deletes ./bin/console

This Flex behavior is debatable

1. composer req cli -> creates ./bin/console
2. Make some changes in ./bin/console contents to customize it for my project
3. composer rem cli -> deletes my customized ./bin/console

My question

Should Flex check the md5 of the file contents before trying to delete them to see if they have been modified?

Whether this proposal is the right thing to do or not is debatable ... but for example Flex doesn't follow the same behavior with dirs:

1. composer req doctrine -> creates the empty src/Entity/ and src/Repository/ dirs
2. Create files in src/Entity/ but not in src/Repository/
3. composer rem doctrine -> removes src/Repository/ but maintains src/Entity/

[nicolas-grekas]

Any changes done by Flex needs to be committed afterwards, so that reverting is not the responsibility of Flex. Maybe we should have some words about the flex+git workflow instead?

[fabpot]

I think the current behavior is the right one. Flex only removes files related to the package you want to uninstall.