-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "sync-recipes --force" option #439
Implement "sync-recipes --force" option #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a way to ignore the lock file also.
Either we use a single --force
parameter that does both (ignore symfony.lock and overwrite existing files)
Or we create two separate arguments if worth it (add --ignore-lock
).
What about |
Everything should be fixed now 👍 |
@nicolas-grekas Tests are fixed, but I have an issue with Windows, I'm sure it's mostly because of the tests and not Flex itself, but it seems that For example, here's a difference in terms of exit code: On windows:
On linux:
In the tests, this is caused by the fact that the test files are located in Should I change the tests so they use files directly in the project so it's covered by Git? Or is there anything to do that would make the tests compatible with both Linux and Windows? Can we put the Flex repo on AppVeyor? 😄 |
Except for some minor changes, I played with the feature and this looks great to me! The experience could be improved, eg:
BUT this would be for future PRs. 👍 |
I fixed the reviews! For the next features, I can create other PRs targeted on this one so we could work on this in parallel without the need for tons of new releases, if you like 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice experience - simple and pragmatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated locally work like a charm after some changed I just push-forced.
👍 Ready to go on my side!
2nd commit fixes symfony/symfony#29510 |
Needs a rebase now that the commands has been renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(rebased + improved a bit meanwhile)
Thank you @Pierstoval. |
Closes #179