Fix travis file name #666
Merged
Fix travis file name #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how to fix PHP nightly stage |
maxhelias
force-pushed
the
fix-travis
branch
5 times, most recently
from
bfb1ee8
to
1624d7c
Compare
|
@nicolas-grekas It should be good, what do you think? |
fabpot
requested changes
Aug 8, 2020
fabpot
approved these changes
Aug 21, 2020
fabpot
reviewed
Aug 21, 2020
| @@ -65,7 +65,7 @@ public function shouldWriteFile(string $file, bool $overwrite): bool | |||
| return true; | |||
| } | |||
|
|
|||
| exec('git status --short --ignored -- '.ProcessExecutor::escape($file).' 2>&1', $output, $status); | |||
| exec('git status --short --ignored --untracked-files=all -- '.ProcessExecutor::escape($file).' 2>&1', $output, $status); | |||
There was a problem hiding this comment.
Is it really needed as it seems to be the default?
There was a problem hiding this comment.
Tested locally and indeed, it is needed.
|
Thank you @maxhelias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.