Fix json-encoding when JSON_THROW_ON_ERROR is used

symfony · Jun 5, 2019 · 7c77e01 · 7c77e01
1 parent ac4ad2b
commit 7c77e01
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/JsonResponse.php b/JsonResponse.php
@@ -153,11 +153,6 @@ public function setData($data = [])
                     restore_error_handler();
                 }
             } else {
-                if (\PHP_VERSION_ID >= 70300 && (JSON_THROW_ON_ERROR & $this->encodingOptions)) {
-                    // Work around https://bugs.php.net/77997
-                    json_encode(null);
-                }
-
                 try {
                     $data = json_encode($data, $this->encodingOptions);
                 } catch (\Exception $e) {
@@ -166,6 +161,10 @@ public function setData($data = [])
                     }
                     throw $e;
                 }
+
+                if (\PHP_VERSION_ID >= 70300 && (JSON_THROW_ON_ERROR & $this->encodingOptions)) {
+                    return $this->setJson($data);
+                }
             }
         }