Added statusCode to parent::_contruct #23
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where I got a
InvalidArgumentException(code: 0)
with the message:The HTTP status code "0" is not valid
while building the response for an exception of the type HttpException.As you can see, at the moment, the parent is getting the $code variable, which is not set.
The thing that is being used is
$statusCode
.This leads to the following:
$exception->getCode
results in 0$exception->getStatusCode
results in a http-status code, like 404.Expected was the following:
$exception->getCode
results in 404$exception->getStatusCode
results 404.This problem only happens when people have a custom exception handler that expects that the inherited
getCode
method form the extended parentException
class can be called...which in this case is being set to0
, even though it is a HttpException.So my proposed solution is to change the constructor
from:
to: