Skip to content

Commit

Permalink
Merge branch '6.4' into 7.0
Browse files Browse the repository at this point in the history
* 6.4:
  Fix implicitly-required parameters
  minor #53524 [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 (smoench)
  Fix bad merge
  List CS fix in .git-blame-ignore-revs
  Fix implicitly-required parameters
  List CS fix in .git-blame-ignore-revs
  Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value
  [Messenger][AmazonSqs] Allow async-aws/sqs version 2
  • Loading branch information
nicolas-grekas committed Jan 23, 2024
2 parents 3c1dea6 + a8bce02 commit 515af50
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Transport/MailgunApiTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class MailgunApiTransport extends AbstractApiTransport
private string $domain;
private ?string $region;

public function __construct(string $key, string $domain, string $region = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $key, string $domain, ?string $region = null, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
$this->key = $key;
$this->domain = $domain;
Expand Down
2 changes: 1 addition & 1 deletion Transport/MailgunHeadersTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*/
trait MailgunHeadersTrait
{
public function send(RawMessage $message, Envelope $envelope = null): ?SentMessage
public function send(RawMessage $message, ?Envelope $envelope = null): ?SentMessage
{
if ($message instanceof Message) {
$this->addMailgunHeaders($message);
Expand Down
2 changes: 1 addition & 1 deletion Transport/MailgunHttpTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class MailgunHttpTransport extends AbstractHttpTransport
private string $domain;
private ?string $region;

public function __construct(string $key, string $domain, string $region = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $key, string $domain, ?string $region = null, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
$this->key = $key;
$this->domain = $domain;
Expand Down
2 changes: 1 addition & 1 deletion Transport/MailgunSmtpTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class MailgunSmtpTransport extends EsmtpTransport
{
use MailgunHeadersTrait;

public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $username, #[\SensitiveParameter] string $password, ?string $region = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 587, false, $dispatcher, $logger);

Expand Down

0 comments on commit 515af50

Please sign in to comment.