Added missing ignore_error option to Configuration #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Parameter was missing.
|
This is fine to add it to the definition but it is not used yet, it should also be added in the MonologExtension around line 256. |
|
Sure, will check it, I must have destroyed that line some how. I had it working locally. Going to mark this PR as WIP Thanks for your feedback! |
mablae
changed the title
mablae
changed the title
mablae
changed the title
|
I would say it's ready to merge, or did I miss anything else? |
Seldaek
added a commit
that referenced
this pull request
Nov 13, 2015
Added missing ignore_error option to Configuration
|
Thanks |
|
I have to thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ignore_erroroption was missing in the Bundle'sConfiguration.php