Use "more entropy" option when using uniqid() function #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
changed the title
|
I was not aware of the usage of usleep in this case. |
|
Thank you @javiereguiluz. |
stof
added a commit
that referenced
this pull request
Oct 3, 2016
…viereguiluz) This PR was merged into the 2.x-dev branch. Discussion ---------- Use "more entropy" option when using uniqid() function As you can see in [the source code of the PHP uniqid() function](https://github.com/php/php-src/blob/1c295d4a9ac78fcc2f77d6695987598bb7abcb83/ext/standard/uniqid.c#L68) when you don't pass `true` as the second argument, PHP sleeps the application for 1 microsecond (`usleep(1)`) Symfony uses `true` almost everywhere, but this bundle still had some uniqid() calls without this option. Commits ------- 2f52c4e Use "more entropy" option when usin uniqid() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in the source code of the PHP uniqid() function when you don't pass
trueas the second argument, PHP sleeps the application for 1 microsecond (usleep(1))Symfony uses
truealmost everywhere, but this bundle still had some uniqid() calls without this option.