Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop DebugHandlerPass #188

Merged
merged 1 commit into from Nov 15, 2016
Merged

Drop DebugHandlerPass #188

merged 1 commit into from Nov 15, 2016

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Nov 8, 2016

Bug fix for 3.0 because this deprecated code should have been removed.
Fixes #187

@andreybolonin
Copy link
Contributor

andreybolonin commented Nov 11, 2016

@nicolas-grekas why is not merged?
Need approve with other symfony members?

@tgalopin
Copy link
Member

This is indeed an issue for anyone using the Standard edition right now, we should consider merging this asap.

@nithinga
Copy link

@stof @fabpot Please take a look into this issue....

@fabpot
Copy link
Member

fabpot commented Nov 15, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit b46da89 into symfony:master Nov 15, 2016
fabpot added a commit that referenced this pull request Nov 15, 2016
This PR was merged into the 3.x-dev branch.

Discussion
----------

Drop DebugHandlerPass

Bug fix for 3.0 because this deprecated code should have been removed.
Fixes #187

Commits
-------

b46da89 Drop DebugHandlerPass
@zerkms
Copy link
Contributor

zerkms commented Nov 23, 2016

So now the DebugHandlerPass is removed and the AddDebugLogProcessorPass is not released yet.

How is it supposed to work?

So either AddDebugLogProcessorPass must be backported to 3.1 ASAP, or these changes reverted.

@lsmith77
Copy link

any plans to make a new MonologBundle release?

@stof
Copy link
Member

stof commented Jan 2, 2017

@nicolas-grekas this change is not good, as you have not dropped support for Symfony < 3.2 when dropping it, while the new pass in Symfony is not available in older versions

@nicolas-grekas nicolas-grekas deleted the drop-debug branch January 2, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated DebugHandlerPass
8 participants