Allow setting "ident" parameter for SyslogUdpHandler, affects #266 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It took time, but here we go, this is in now. Thank you very much Daniel. |
lyrixx
added a commit
that referenced
this pull request
May 16, 2019
…fects #266 (dhirtzbruch) This PR was merged into the 3.x-dev branch. Discussion ---------- Allow setting "ident" parameter for SyslogUdpHandler, affects #266 As outlined in ticket #266: The SyslogUdpHandler constructor has a sixth parameter "ident", defaulting to "php". However, the current Monolog Bundle implementation allows setting only the first five. Which defaults to the "ident" being set to "php". In our case, we are using papertrail as a log backend, and use the same webserver for multiple small projects. In papertrail, that results in the following output: ``` May 05 02:16:30 vagrant php: app.ERROR: fooo {"exception":"[object] (Exception(code: 0): fooo at /var/customers/webs/fastbolt/https/env1.fastbolt.com/src/Pricecalc/UserBundle/Controller/SecurityController.php:36)","username":"anon.","uri":"http://env1.dev.local/login","level":"critical"} [] May 05 02:18:32 vagrant php: app.ERROR: fooo {"exception":"[object] (Exception(code: 0): fooo at /var/customers/webs/fastbolt/https/env2.fastbolt.com/src/Pricecalc/UserBundle/Controller/SecurityController.php:36)","username":"anon.","uri":"http://env2.dev.local/login","level":"critical"} [] ``` The "php" after "vagrant" is the ident configuration. As you can see, we are not able to determine the source environment, other than guessing from filepath or uri. However, for filtering using the API, we`d like to be able to change the ident per configuration. ``` monolog: handlers: syslog: type: syslogudp host: example.com port: 514 level: error ident: env1 ``` Using that config, we should be able to achieve the following log: ``` May 05 02:16:30 vagrant env1: app.ERROR: fooo {"exception":"[object] (Exception(code: 0): fooo at /var/customers/webs/fastbolt/https/env1.fastbolt.com/src/Pricecalc/UserBundle/Controller/SecurityController.php:36)","username":"anon.","uri":"http://env1.dev.local/login","level":"critical"} [] May 05 02:18:32 vagrant env2: app.ERROR: fooo {"exception":"[object] (Exception(code: 0): fooo at /var/customers/webs/fastbolt/https/env2.fastbolt.com/src/Pricecalc/UserBundle/Controller/SecurityController.php:36)","username":"anon.","uri":"http://env2.dev.local/login","level":"critical"} [] ``` Please let me know if there is anything else I should do, as that`s my first PR/issue here. Commits ------- 9f6f0b6 Allow setting "ident" parameter for SyslogUdpHandler, affects #266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in ticket #266:
The SyslogUdpHandler constructor has a sixth parameter "ident", defaulting to "php".
However, the current Monolog Bundle implementation allows setting only the first five. Which defaults to the "ident" being set to "php".
In our case, we are using papertrail as a log backend, and use the same webserver for multiple small projects. In papertrail, that results in the following output:
The "php" after "vagrant" is the ident configuration. As you can see, we are not able to determine the source environment, other than guessing from filepath or uri.
However, for filtering using the API, we`d like to be able to change the ident per configuration.
Using that config, we should be able to achieve the following log:
Please let me know if there is anything else I should do, as that`s my first PR/issue here.