Added Slack support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You would have to update the XSD as well. |
|
👍 |
| $handler['use_attachment'], | ||
| $handler['level'], | ||
| $handler['bubble'], | ||
| $handler['icon_emoji'], |
There was a problem hiding this comment.
This needs to be moved before level again (sorry for the back and forth:)
|
Ok. This should be good now. Didn't realise you'd changed the core bundle :) |
| @@ -55,6 +55,11 @@ | |||
| <xsd:attribute name="dsn" type="xsd:string" /> | |||
| <xsd:attribute name="client-id" type="xsd:string" /> | |||
| <xsd:attribute name="use-ssl" type="xsd:boolean" /> | |||
| <xsd:attribute name="username" type="xsd:string" /> | |||
There was a problem hiding this comment.
I think this one isn't necessary anymore? It doesn't seem to be used anywhere at least.
|
I'll merge and remove the username thing from the xsd myself as the rest looks good. |
|
Thanks |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added required parameters and nodes to support the monolog SlackHandler. Requires Seldaek/monolog#413