Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop version constraint to allow future package releases (or abandon package) #22

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@goetas
Copy link
Contributor

goetas commented Feb 9, 2020

I can immagine that this is going to be a bit controversial, but I'm not sure if this package was a good idea.

When users use symfony/orm-pack they get some doctrine packages as "doctrine/doctrine-migrations-bundle", versions ^1. or ^2.0,

When doctrine/doctrine-migrations-bundle 3.0 will be released (or orm 3.0 or dbal 2.0), the only way to allow the upgrade it is to allow it in this package, as example defining doctrine/doctrine-migrations-bundle: ^1.3|^2.0|3.0 (an example was c8b2fd4)

But since that was a minor/bigfix release, any user that had installed symfony/orm-pack got automatically installed (as bugfix) doctrine/doctrine-migrations-bundle 2.0 that was a major release with BC breaks. This already was reported in #15, I'm not aware of packs being unpacked by composer... is that true?

My proposal to remove the version constraint has the same disadvantages, but does not oblige the doctrine team to keep updated this repo each time there is a major release on doctrine.

Another solution is that each time a major release is added in the constraints, this package should release a major release, in this way we avoid delivering unexpected major releases. Similar as #18

A third solution (that does not exclude the previous one) is to deprecate this package and let users install what do they need.

Copy link
Member

nicolas-grekas left a comment

Ppl should unpack their deps for greater control.

@goetas

This comment has been minimized.

Copy link
Contributor Author

goetas commented Feb 9, 2020

Ppl should unpack their deps for greater control.

how should that happen? is there any tool or explicit flow to do that? if is just "people should" then "people won't"

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 9, 2020

Sure, flex provides an "unpack" composer command exactly for this purpose.

@goetas

This comment has been minimized.

Copy link
Contributor Author

goetas commented Feb 9, 2020

Should flex unpack automatically while installing the pack packages?

@fabpot fabpot merged commit c9bcc08 into symfony:master Feb 10, 2020
@blry

This comment has been minimized.

Copy link

blry commented on 1000287 Feb 13, 2020

Hi @goetas

After update, I can't run console, get some errors. I tried to use add these packages explicitly with old versions and it started to work
"doctrine/orm": "^2.5.11",
"doctrine/doctrine-bundle": "^1.6.10|^2.0",
"doctrine/doctrine-migrations-bundle": "^1.3|^2.0",

Executing script cache:clear [KO]
[KO]
Script cache:clear returned with error code 1
!! PHP Warning: zend.assertions may be completely enabled or disabled only in php.ini in /var/www/vendor/symfony/error-handler/Debug.php on line 32
!! PHP Stack trace:
!! PHP 1. {main}() /var/www/bin/console:0
!! PHP 2. Symfony\Component\ErrorHandler\Debug::enable() /var/www/bin/console:36
!! PHP 3. ini_set() /var/www/vendor/symfony/error-handler/Debug.php:32
!!
!! In ArrayNode.php line 319:
!!
!! Unrecognized options "dir_name, namespace" under "doctrine_migrations". Ava
!! ilable options are "all_or_nothing", "check_database_platform", "connection
!! ", "custom_template", "em", "migrations", "migrations_paths", "name", "orga
!! nize_migrations", "services", "storage".

This comment has been minimized.

Copy link
Member

nicolas-grekas replied Feb 13, 2020

The warning is fixed in symfony/symfony#35710

This comment has been minimized.

Copy link

blry replied Feb 13, 2020

@nicolas-grekas does it relate to "unrecognized options 'dir_name, namespace' under 'doctrine_migrations'" exception (doctrine_migrations.yaml)? Got this on Symfony 5

This comment has been minimized.

Copy link
Member

nicolas-grekas replied Feb 13, 2020

Nope

This comment has been minimized.

Copy link
Contributor Author

goetas replied Feb 14, 2020

Are you using minimum stability dev? It seems that you got the unreleased master version of doctrine migrations bundle

This comment has been minimized.

Copy link
Contributor Author

goetas replied Feb 14, 2020

Probably you did not unpack the pack package.

I expressed my opinion in #22 (comment) for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.