Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessing PantherTestCaseTrait::$webServerDir before initialization #523

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fix accessing PantherTestCaseTrait::$webServerDir before initialization #523

merged 1 commit into from
Dec 2, 2021

Conversation

kbond
Copy link
Member

@kbond kbond commented Dec 1, 2021 •
edited

PantherTestCaseTrait::getWebServerDir() can access PantherTestCaseTrait::$webServerDir before it's initialized. I believe this was just missed in #517.

@chalasr
Copy link
Member

chalasr commented Dec 2, 2021

Good catch, thanks @kbond.

@chalasr chalasr merged commit dc57282 into symfony:main Dec 2, 2021
@kbond kbond deleted the nullable-prop branch December 2, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbond @chalasr