Skip to content

Commit

Permalink
Use a more appropriate group when deprecating mode
Browse files Browse the repository at this point in the history
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.
  • Loading branch information
greg0ire committed May 30, 2019
1 parent 7bfc1b5 commit 4c02cf1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DeprecationErrorHandler.php
Expand Up @@ -228,9 +228,9 @@ private function getConfiguration()
return $this->configuration = Configuration::inWeakMode();
}
if (self::MODE_WEAK_VENDORS === $mode) {
++$this->deprecations['remaining selfCount'];
++$this->deprecations['remaining directCount'];
$msg = sprintf('Setting SYMFONY_DEPRECATIONS_HELPER to "%s" is deprecated in favor of "max[self]=0"', $mode);
$ref = &$this->deprecations['remaining self'][$msg]['count'];
$ref = &$this->deprecations['remaining direct'][$msg]['count'];
++$ref;
$mode = 'max[self]=0';
}
Expand Down

0 comments on commit 4c02cf1

Please sign in to comment.