Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_countable, not Big Endian safe? #134

Closed
LocutusOfBorg opened this issue Jul 23, 2018 · 3 comments
Closed

is_countable, not Big Endian safe? #134

LocutusOfBorg opened this issue Jul 23, 2018 · 3 comments

Comments

@LocutusOfBorg
Copy link

Hello, I see a possible endianess issue on is_countable testsuite and latest polyfill release 1.8.0
https://autopkgtest.ubuntu.com/packages/php-symfony-polyfill/cosmic/s390x

Setting up autopkgtest-satdep (0) ...
(Reading database ... 73688 files and directories currently installed.)
Removing autopkgtest-satdep (0) ...
autopkgtest [16:09:03]: test command1: phpunit --bootstrap /usr/share/php/Symfony/Polyfill/autoload.php
autopkgtest [16:09:03]: test command1: [-----------------------
PHPUnit 7.2.7 by Sebastian Bergmann and contributors.

SSS............................................................  63 / 766 (  8%)
............................................................... 126 / 766 ( 16%)
............................................................... 189 / 766 ( 24%)
............................................................... 252 / 766 ( 32%)
............................................................... 315 / 766 ( 41%)
..............................................................S 378 / 766 ( 49%)
SS..F.SSS...................................................... 441 / 766 ( 57%)
............................................................... 504 / 766 ( 65%)
............................................................... 567 / 766 ( 74%)
............................................................... 630 / 766 ( 82%)
............................................................... 693 / 766 ( 90%)
............................................................... 756 / 766 ( 98%)
.....SSS..                                                      766 / 766 (100%)

Time: 2.22 seconds, Memory: 18.22MB

There was 1 failure:

1) Symfony\Polyfill\Tests\Php73\Php73Test::testIsCountable
Failed asserting that false is true.

/tmp/autopkgtest.Lf6G0W/build.nrL/src/tests/Php73/Php73Test.php:27

FAILURES!
Tests: 778, Assertions: 726412, Failures: 1, Skipped: 12.

I'm tempted to disable this part of the testsuite, since php 7.3 is not yet a real thing, and nothing is using is_countable in the archive, and this is a new test... but can you please have a look, or tell me if this is not a real issue?

the architecture is s390x

@nicolas-grekas
Copy link
Member

I don't know if intl-resource bundles are endian-safe or not: maybe tests/Php73/fixtures/en.res cannot be read on big endian archs? Does this test pass on PHP 7.2? If yes, could it be a PHP bug?

@LocutusOfBorg
Copy link
Author

@nicolas-grekas
Copy link
Member

Fixed in #140

nicolas-grekas added a commit that referenced this issue Aug 5, 2018
…ekas)

This PR was merged into the 1.8-dev branch.

Discussion
----------

skip ResourceBundle test on big endian systems

Fixes #134

Commits
-------

61aa24c skip ResourceBundle test on big endian systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants