[Uuid] Added the polyfill #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 30, 2019
lyrixx
force-pushed
the
uuid
branch
2 times, most recently
from
47e8c87
to
e3cf6b8
Compare
dunglas
reviewed
Oct 31, 2019
stof
reviewed
Oct 31, 2019
stof
reviewed
Oct 31, 2019
lyrixx
force-pushed
the
uuid
branch
3 times, most recently
from
92e68e2
to
2734db4
Compare
|
I think this PR is ready 🎉 |
|
based on #197 (comment) (and my answer just after), it is not, as the error handling is not the same in the polyfill and in the original extension. |
lyrixx
force-pushed
the
uuid
branch
3 times, most recently
from
84c241b
to
c12cfb3
Compare
|
OK, I removed all the type hints and codes incompatible with PHP > 5.3 Should be really ready now 😄 |
jderusse
reviewed
Nov 6, 2019
jderusse
reviewed
Nov 6, 2019
xelan
reviewed
Nov 7, 2019
nicolas-grekas
approved these changes
Nov 12, 2019
stof
reviewed
Nov 15, 2019
stof
approved these changes
Nov 15, 2019
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2019
This PR was squashed before being merged into the 1.12-dev branch. Discussion ---------- [Uuid] Added the polyfill Commits ------- 9b6d18b [Uuid] Added the polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.