Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mb_check_encoding with array value #426

Merged
merged 1 commit into from Jan 30, 2023

Conversation

jeremyFreeAgent
Copy link
Contributor

I tried to address the #422 issue.

First time on that project. I'm not sure about what I've done because I'm afraid we cannot do anything for PHP <7.2.

@alexandre-daubois
Copy link
Contributor

Caution, the doc tells that values passed as array are validated recursively 🙂

@jeremyFreeAgent
Copy link
Contributor Author

Caution, the doc tells that values passed as array are validated recursively 🙂

Thanks!

@derrabus
Copy link
Member

Let's kill PHP 7.1 then, shall we? #428

src/Mbstring/Mbstring.php Outdated Show resolved Hide resolved
tests/Mbstring/MbstringTest.php Outdated Show resolved Hide resolved
@stof
Copy link
Member

stof commented Jan 30, 2023

For PHP 7.1, we need to emulate the PHP 7.1 behavior of mbstring, which is not supporting arrays (as we cannot make a project using PHP 7.1 with native mbstring support arrays by installing the polyfill as it would not replace the native functions).
That's totally possible to emulate (triggering the warning and returning null)

@jeremyFreeAgent
Copy link
Contributor Author

Thank you @stof and @nicolas-grekas for the PHP < 7.2 behaviour.

@nicolas-grekas
Copy link
Member

Thank you @jeremyFreeAgent.

@nicolas-grekas nicolas-grekas merged commit e2fbb83 into symfony:main Jan 30, 2023
@jeremyFreeAgent jeremyFreeAgent deleted the mb_check_encoding branch January 30, 2023 17:26
@staabm
Copy link

staabm commented Mar 27, 2023

thx for merging. it seems this fix is not yet part of any release..? is there a timeline when this gets released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants