Add case folding map #427
Merged
Add case folding map #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 28, 2023
There was a problem hiding this comment.
The merged map is available in https://github.com/symfony/string/blob/6.2/AbstractUnicodeString.php (and it looks like there are some duplicates in there? to be fixed also)
|
Please have a look at failing tests, they might be related. |
alexandre-daubois
force-pushed
the
case-folding
branch
from
fa76f9b
to
c132a51
Compare
|
Updated the map 👍 Removed duplicates also in Symfony: symfony/symfony#49159, thanks for pointing this out! I'm checking the tests. they seem a bit tricky as some characters are being case folded by two chars, which introduces an offset when it comes to |
alexandre-daubois
force-pushed
the
case-folding
branch
3 times, most recently
from
9fe0792
to
176bf2e
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 1, 2023
This PR was merged into the 5.4 branch. Discussion ---------- [String] Remove duplicates in fold maps | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Related to symfony/polyfill#427 | License | MIT | Doc PR | _NA_ Commits ------- 858c6e9 [String] Remove duplicates in fold maps
nicolas-grekas
force-pushed
the
case-folding
branch
2 times, most recently
from
d1ff0bc
to
0cf134b
Compare
alexandre-daubois
force-pushed
the
case-folding
branch
from
2a628cc
to
a6cb6ad
Compare
OskarStark
approved these changes
Feb 4, 2023
nicolas-grekas
force-pushed
the
case-folding
branch
from
a6cb6ad
to
e87fe20
Compare
nicolas-grekas
force-pushed
the
case-folding
branch
from
e87fe20
to
3d151ba
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
@nicolas-grekas, I've indeed borrowed the map you pointed at in the issue. Thanks for this!