[PHP 8.3] Polyfill new non-overloaded variants of functions #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
force-pushed
the
feature/no-overload
branch
4 times, most recently
from
95c0916
to
7ad2dc3
Compare
nicolas-grekas
approved these changes
Jul 31, 2023
|
Can you also please update the changelog? |
|
Updated, @nicolas-grekas but I noticed that changelog mentions v1.28 too which hasn't been released 馃. Is this expected? |
nicolas-grekas
force-pushed
the
feature/no-overload
branch
from
6b7b28b
to
8066764
Compare
|
Thank you @IonBazan. |
Good catch, fixed in e204dfd Anything else we should add to 1.28 before releasing it? |
|
I think we're good. Maybe you can try to test it in a real-life application? I didn't have a chance to test the LDAP-related functionality 馃檲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add new PHP 8.3 functions introduced with RFC: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures
Comments and feedback welcome 馃檹馃徎
array_keys_filter(rejected)Fixes #436