Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type for Locale::parseLocale - it can return null #449

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix return type for Locale::parseLocale - it can return null #449

merged 1 commit into from
Sep 29, 2023

Conversation

andrew-demb
Copy link
Contributor

https://www.php.net/manual/en/locale.parselocale.php

Returns null when the length of locale exceeds INTL_MAX_LOCALE_LEN.

Recreated PR from symfony/polyfill-intl-icu#1

@andrew-demb
Copy link
Contributor Author

CI failure is unrelated

@nicolas-grekas
Copy link
Member

Thank you @andrew-demb.

@nicolas-grekas nicolas-grekas merged commit ea7fa87 into symfony:1.x Sep 29, 2023
6 of 9 checks passed
@andrew-demb andrew-demb deleted the patch-1 branch September 29, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-demb @nicolas-grekas @derrabus