Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add str_increment and str_decrement functions #453

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Fan2Shrek
Copy link
Contributor

@Fan2Shrek Fan2Shrek commented Oct 13, 2023

Add implementations of str_increment and str_decrement functions

PS: It's my first PR to open source, feel free to give me feedback !

Fixes #452

@Fan2Shrek Fan2Shrek force-pushed the feat/str-functions branch 3 times, most recently from bc8d395 to da0d571 Compare October 13, 2023 19:12
src/Php83/Php83.php Outdated Show resolved Hide resolved
tests/Php83/Php83Test.php Outdated Show resolved Hide resolved
@OskarStark OskarStark changed the title Add str_increment and str_decrement functions Add str_increment and str_decrement functions Oct 13, 2023
@Fan2Shrek Fan2Shrek force-pushed the feat/str-functions branch 2 times, most recently from fae5108 to eaee961 Compare October 13, 2023 21:53
src/Php83/Php83.php Outdated Show resolved Hide resolved
tests/Php83/Php83Test.php Outdated Show resolved Hide resolved
@Fan2Shrek Fan2Shrek force-pushed the feat/str-functions branch 10 times, most recently from 2ebf57d to 415f794 Compare October 17, 2023 05:46
@Fan2Shrek Fan2Shrek requested a review from stof October 18, 2023 06:58
src/Php83/Php83.php Outdated Show resolved Hide resolved
src/Php83/Php83.php Outdated Show resolved Hide resolved
src/Php83/Php83.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

Thank you @Fan2Shrek.

@nicolas-grekas nicolas-grekas merged commit 8a41c5a into symfony:1.x Jan 10, 2024
6 of 9 checks passed
Ayesh added a commit to Ayesh/polyfill that referenced this pull request Jan 10, 2024
nicolas-grekas added a commit that referenced this pull request Jan 29, 2024
…_decrement` functions (Ayesh)

This PR was merged into the 1.x branch.

Discussion
----------

[PHP 8.3] Update README file with `str_increment` and `str_decrement` functions

Related: #453 and #452

Commits
-------

51963b4 [PHP 8.3] Update README file with `str_increment` and `str_decrement` functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing str_increment and str_decrement polyfill
5 participants