fix for Process:isSuccessful()

symfony · Aug 21, 2013 · 0f58865 · 0f58865
1 parent d58a1e3
commit 0f58865
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/Process.php b/Process.php
@@ -489,7 +489,7 @@ public function getExitCodeText()
      */
     public function isSuccessful()
     {
-        return 0 == $this->getExitCode();
+        return 0 === $this->getExitCode();
     }
 
     /**

diff --git a/Tests/AbstractProcessTest.php b/Tests/AbstractProcessTest.php
@@ -277,6 +277,18 @@ public function testIsSuccessful()
         $this->assertTrue($process->isSuccessful());
     }
 
+    public function testIsSuccessfulOnlyAfterTerminated()
+    {
+        $process = $this->getProcess('sleep 1');
+        $process->start();
+        while ($process->isRunning()) {
+            $this->assertFalse($process->isSuccessful());
+            usleep(300000);
+        }
+
+        $this->assertTrue($process->isSuccessful());
+    }
+
     public function testIsNotSuccessful()
     {
         $process = $this->getProcess('php -r "sleep(4);"');

diff --git a/Tests/SigchildDisabledProcessTest.php b/Tests/SigchildDisabledProcessTest.php
@@ -80,6 +80,14 @@ public function testIsSuccessful()
         parent::testIsSuccessful();
     }
 
+    /**
+     * @expectedException \Symfony\Component\Process\Exception\RuntimeException
+     */
+    public function testIsSuccessfulOnlyAfterTerminated()
+    {
+        parent::testIsSuccessfulOnlyAfterTerminated();
+    }
+
     /**
      * @expectedException \Symfony\Component\Process\Exception\RuntimeException
      */