Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative for disabled escapeshellarg() function #14

Closed
wants to merge 1 commit into from

Conversation

alvaro-canepa
Copy link

No description provided.

@Garbee
Copy link

Garbee commented Feb 8, 2017

Can we please get some kind of signal as to what should be done here to have this PR merged? It does need a rebase, but other than that are there any tests to be written or questions about the change?

Other projects rely on this which currently doesn't work in some shared hosting environments. This is because for some odd reason they turn off security features. So, it would be nice to have this check in place to function equally in environments with the internal function turned off. As it is, any project depending upon this package doesn't work when escapeshellarg is disabled via php.ini.

Thank you.

@Garbee
Copy link

Garbee commented Feb 8, 2017

Oh, just realized this is a read-only split. So the commit needs to go into a higher-level repository it looks like.

@Garbee
Copy link

Garbee commented Feb 8, 2017

Looks like symfony/symfony is where this should be requested at.

@nicolas-grekas
Copy link
Member

Closing as this has been already fixed in recent versions, which don't use the function anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants