Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5.0 #69

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Allow Symfony 5.0 #69

merged 1 commit into from
Nov 25, 2019

Conversation

rbaarsma
Copy link

No description provided.

@rbaarsma rbaarsma marked this pull request as ready for review November 23, 2019 12:44
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

#SymfonyHackday

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with two minor comments)

@rbaarsma rbaarsma mentioned this pull request Nov 23, 2019
@rbaarsma
Copy link
Author

@nicolas-grekas any chance you can merge this and create a version? Would help me update other bundles to Symfony 5 that depend on this one :)

@nicolas-grekas nicolas-grekas changed the title updated to minimum symfony 4.4 and php 7.1, fixed tests and removed deprecations Allow Symfony 5.0 Nov 25, 2019
@nicolas-grekas
Copy link
Member

Thank you @rbaarsma.

nicolas-grekas added a commit that referenced this pull request Nov 25, 2019
This PR was merged into the 1.2-dev branch.

Discussion
----------

Allow Symfony 5.0

Commits
-------

1158149 Allow Symfony 5.0
@nicolas-grekas nicolas-grekas merged commit 1158149 into symfony:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants