Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the sroze/openwhisk-bundle recipe #126

Merged
3 commits merged into from Oct 30, 2017

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Oct 29, 2017

Q A
License MIT

This recipe will automatically create the Openwhisk entry point for the action (or "cloud function").
This makes Symfony deployable to Openwhisk in almost one composer req.

Replaces #124 because of the issue #125.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@sroze
Copy link
Contributor Author

sroze commented Oct 29, 2017

It actually has the same #125 issue 😅

@fabpot
Copy link
Member

fabpot commented Oct 29, 2017

@sroze You can test it now (it works for me after my hotfix :)). Tell me if everything works fine for you.

@fabpot
Copy link
Member

fabpot commented Oct 29, 2017

Not sure if this is relevant to add this here. It looks more like an example than something that can be used as is. A recipe should not replace documentation. Can you explain a bit more about how one would us it in the context of an app managed by Flex?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@sroze sroze changed the title Add the sroze/openwhisk-bundle recipe [WIP] Add the sroze/openwhisk-bundle recipe Oct 29, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@sroze sroze changed the title [WIP] Add the sroze/openwhisk-bundle recipe Add the sroze/openwhisk-bundle recipe Oct 29, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@sroze
Copy link
Contributor Author

sroze commented Oct 29, 2017

@fabpot super, it worked, thanks 👍

This is the front-controller of your application if running it within an openwhisk function. (it replaces the public/index.php file). Therefore, when you req sroze/openwhisk-bundle one your Symfony application, it makes it directly "deployable" on such platform. (I will try to provide a much deeper explanation in a blog-post very soon).

@fabpot
Copy link
Member

fabpot commented Oct 29, 2017

I understand that, but then, the public directory is not needed anymore, right?

@sroze
Copy link
Contributor Author

sroze commented Oct 29, 2017

Haha, I love it. Even easier than I thought to integrate with the Debug Toolbar 😜 The "proof of work" captcha is a great idea, if we make it a "proof of issue" ... 💸

You're right. But the public directory is still useful when working on the application from the developer's laptop, so I'd keep it. By the way, this index.php is at the root folder because it's a limitation of the Openwhisk PHP integration.

@sroze sroze changed the title Add the sroze/openwhisk-bundle recipe [WIP] Add the sroze/openwhisk-bundle recipe Oct 29, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@sroze sroze changed the title [WIP] Add the sroze/openwhisk-bundle recipe Add the sroze/openwhisk-bundle recipe Oct 29, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

},
"gitignore": [
"/.serverless",
"/node_modules"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not related to the bundle, but more generic. Is it something we want by default in the symfony/framework-bundle recipe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.. none of these are related to openwhisk directly either 🤔 I'll remove them from this PR.

/node_modules/ is already in the webpack-encore-pack manifest so I guess it's alright for us.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit cf9c677 into symfony:master Oct 30, 2017
ghost pushed a commit that referenced this pull request Oct 30, 2017
@sroze sroze deleted the add-sroze-openwhisk-router branch October 31, 2017 08:51
@sroze
Copy link
Contributor Author

sroze commented Oct 31, 2017

I really like this symfony-flex-server 👍

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants