New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the sroze/openwhisk-bundle recipe #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
It actually has the same #125 issue 😅 |
@sroze You can test it now (it works for me after my hotfix :)). Tell me if everything works fine for you. |
Not sure if this is relevant to add this here. It looks more like an example than something that can be used as is. A recipe should not replace documentation. Can you explain a bit more about how one would us it in the context of an app managed by Flex? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
@fabpot super, it worked, thanks 👍 This is the front-controller of your application if running it within an openwhisk function. (it replaces the |
I understand that, but then, the |
Haha, I love it. Even easier than I thought to integrate with the Debug Toolbar 😜 The "proof of work" captcha is a great idea, if we make it a "proof of issue" ... 💸 You're right. But the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
}, | ||
"gitignore": [ | ||
"/.serverless", | ||
"/node_modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not related to the bundle, but more generic. Is it something we want by default in the symfony/framework-bundle
recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually.. none of these are related to openwhisk directly either 🤔 I'll remove them from this PR.
/node_modules/
is already in the webpack-encore-pack
manifest so I guess it's alright for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
I really like this symfony-flex-server 👍 |
This recipe will automatically create the Openwhisk entry point for the action (or "cloud function").
This makes Symfony deployable to Openwhisk in almost one
composer req
.Replaces #124 because of the issue #125.