-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for phpsword/sword-bundle #1433
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
332e2e4
to
a1ad8e8
Compare
"config/": "%CONFIG_DIR%/" | ||
}, | ||
"copy-from-package": { | ||
"install/bin/console": "%BIN_DIR%/console", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would override Symfony's own console script. That's a no go IMHO.
"install/wp/wp-config.php": "wp/wp-config.php", | ||
"install/docker/": "docker/", | ||
"install/docker-compose.yml": "docker-compose.yml", | ||
"install/docker-compose.prod.yml": "docker-compose.prod.yml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a specific mechanism to add entries in Docker files that should be used instead (to avoid overriding the ones from Symfony).
Closing for now. Feel free to reopen when/if you have time to finish this PR. Thank you. |
Pull request was closed
Hi, really sorry I didn't notice the review! I've made the changes in my branch to remove the problematic files from the recipe manifest. |
@williarin I think you're the only one able to reopen it. If not, can you just submit a new one? |
Recipe for phpsword/sword-bundle.