Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for phpsword/sword-bundle #1433

Closed
wants to merge 1 commit into from

Conversation

williarin
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1433/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1433/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'phpsword/sword-bundle:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled September 8, 2022 06:34

Head branch was pushed to by a user without write access

"config/": "%CONFIG_DIR%/"
},
"copy-from-package": {
"install/bin/console": "%BIN_DIR%/console",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would override Symfony's own console script. That's a no go IMHO.

"install/wp/wp-config.php": "wp/wp-config.php",
"install/docker/": "docker/",
"install/docker-compose.yml": "docker-compose.yml",
"install/docker-compose.prod.yml": "docker-compose.prod.yml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a specific mechanism to add entries in Docker files that should be used instead (to avoid overriding the ones from Symfony).

@fabpot
Copy link
Member

fabpot commented Dec 30, 2022

Closing for now. Feel free to reopen when/if you have time to finish this PR. Thank you.

@fabpot fabpot closed this Dec 30, 2022
auto-merge was automatically disabled December 30, 2022 09:35

Pull request was closed

@williarin
Copy link
Contributor Author

Hi, really sorry I didn't notice the review! I've made the changes in my branch to remove the problematic files from the recipe manifest.
Could the PR be reopened?

@fabpot
Copy link
Member

fabpot commented Dec 30, 2022

@williarin I think you're the only one able to reopen it. If not, can you just submit a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants