phpzlc v2

[CJayHe]

Q	A
License	MIT
Packagist

[github-actions]

Thanks for the PR 😍

How to test these changes in your application

1. Define the SYMFONY_ENDPOINT environment variable:

   # On Unix-like (BSD, Linux and macOS)
   export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1444/index.json
   # On Windows
   SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1444/index.json

2. Install the package(s) related to this recipe:

   composer req 'symfony/flex:^1.16'
   composer req 'phpzlc/admin-business:^2.0' 'phpzlc/area-business:^2.0' 'phpzlc/phpzlc:^2.4' 'phpzlc/upload-business:^2.0'

3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

   # On Unix-like (BSD, Linux and macOS)
   unset SYMFONY_ENDPOINT
   # On Windows
   SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

phpzlc/admin-business

1.0 vs 2.0

phpzlc/phpzlc

1.0 vs 2.0

diff --git a/phpzlc/phpzlc/1.0/manifest.json b/phpzlc/phpzlc/2.0/manifest.json
index 6063d6a2..d83b1037 100644
--- a/phpzlc/phpzlc/1.0/manifest.json
+++ b/phpzlc/phpzlc/2.0/manifest.json
@@ -4,6 +4,7 @@
     },
     "copy-from-package": {
         "Doctrine/ORM/Rewrite/Templates/Repository.tpl.php": "vendor/symfony/maker-bundle/src/Resources/skeleton/doctrine/Repository.tpl.php",
+        "Doctrine/ORM/Rewrite/Hydration/AbstractHydrator.php": "vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php",
         "Doctrine/ORM/Rewrite/Hydration/ObjectHydrator.php": "vendor/doctrine/orm/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php",
         "Doctrine/ORM/Rewrite/MakeEntityRegenerate/ClassSourceManipulator.php": "vendor/symfony/maker-bundle/src/Util/ClassSourceManipulator.php",
         "Doctrine/ORM/Rewrite/MakeEntityRegenerate/EntityRegenerator.php": "vendor/symfony/maker-bundle/src/Doctrine/EntityRegenerator.php",

2.0 vs 2.3

2.3 vs 2.4

phpzlc/upload-business

1.0 vs 2.0

[fabpot]

I have a hard figuring out what you're trying to do here.
A recipe is mainly helpful when we want to add some configuration files.
We tend to avoid adding PHP classes as this is more for maker bundle.

[fabpot]

None of these directories exist, so the whole file can be removed.

[CJayHe]

The purpose of copying here is to copy some written business code to the corresponding location of the project. These codes can be easily reused and adjusted according to the current project.

[fabpot]

Oh sorry, I read too fast, that's a copy from package, not recipe.
I think that's something that will work long-term.
Just one example. Your entities are probably using annotations or attributes. Depending on what the user has configured, it will work or not.
So, instead, you should probably have a command that copies/generates/customizes those files. This command to be run can be advertized in a post install message (that's a recommendation I've made in the last few weeks in many similar PRs here).

[CJayHe]

I know what you mean, and I've thought about it too, but I think it will make the installation more complicated and inconvenient.

1. Almost all of my packages need to do this, which means I have to execute extra commands every time.
2. Executing copy is the same thing as symfony-flex, which means I have developed symfony-flex repeatedly.
3. symfony-flex is great in my opinion. It was also intended to be easy to install.
4. These configurations of mine have to work, there is no alternative.

[fabpot]

Then, I fear that your packages are not a good fit for recipes :(
We want recipes that work for all use cases, not just one specific one.
To generate files, we have maker bundle, that's probably what you want to extend here.
Recipes are a way to configure things.
Another issue with copying PHP files that need to be heavily changed by the user: when one wants to update their recipes, they will get plenty of conflicts.

[CJayHe]

Thank you for your guidance.
But for now in my scenario, using symfy-flex is the best solution.

1. If you change the method, you need to write a component like symfy-flex. The functionality written is not as good as the Symfony-Flex experience, which as a symfony user I don't think is cool.
2. Secondly, I think even if the method is changed, the problem will not be reduced, because the principle and purpose of the two are the same, so the situation is similar.

[fabpot]

Same here

[fabpot]

What if Marker bundle is not installed?

[CJayHe]

composer package phpzlc/phpzlc will decide who to rely on

[fabpot]

Oh sorry, I read too fast, that's a copy from package, not recipe.
I think that's something that will work long-term.
Just one example. Your entities are probably using annotations or attributes. Depending on what the user has configured, it will work or not.
So, instead, you should probably have a command that copies/generates/customizes those files. This command to be run can be advertized in a post install message (that's a recommendation I've made in the last few weeks in many similar PRs here).