Add NelmioApiDocBundle 3.0 support #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
This was referenced Jan 3, 2018
dbu
reviewed
Jan 4, 2018
| NelmioApiDocBundle: | ||
| # Requires the Asset component and the Twig bundle | ||
| resource: "@NelmioApiDocBundle/Resources/config/routing/swaggerui.xml" | ||
| prefix: /api/doc |
There was a problem hiding this comment.
should this include a commented out definition for exposing the swaggerdoc json as well? (it should not be on by default, but having it in here seems useful to me)
path: /api/doc.json
methods: GET
defaults: { _controller: nelmio_api_doc.controller.swagger }
dbu
reviewed
Jan 4, 2018
| methods: GET | ||
| defaults: { _controller: nelmio_api_doc.controller.swagger_ui } | ||
|
|
||
| # app.swagger: |
There was a problem hiding this comment.
i think this should have a comment above this line what it does
fabpot
approved these changes
Jan 4, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197 and #207