Add support for Roukmoute Hashids bundle

[roukmoute]

Q	A
License	MIT

[ghost]

Pull request does not pass validation.

[ghost]

Pull request does not pass validation.

[ghost]

Pull request passes validation.

[javiereguiluz]

@roukmoute thanks for this contribution! We try to minimize the number of env vars because they are very problematic to manage for lots of people. So, I'm asking if you think that these four config options should really be env vars or they could be just normal config params. We do that in most of our recipes. For example in https://github.com/symfony/recipes-contrib/blob/master/doctrine/mongodb-odm-bundle/3.3/config/packages/doctrine_mongodb.yaml we just define two env vars for some really special params ... but the rest are normal params. Thanks!

[roukmoute]

@javiereguiluz Of course I can do that :)
In fact in my repository, this is like you suggest.
I will fix it.

[ghost]

Pull request does not pass validation.

[ghost]

Pull request does not pass validation.

[ghost]

Pull request passes validation.

[Nyholm]

Isn’t these settings same as the default config? I suggest remove all except for “salt” and them add a value like “change me”. It would also be great with a link to the docs.

[ghost]

Pull request passes validation.

[ghost]

Pull request passes validation.

[roukmoute]

Done @Nyholm :)

[ghost]

Pull request passes validation.

[Nyholm]

Great. Can you just make sure Travis is happy?

[roukmoute]

I try but currently I have some troubles to test it in local:

                                                                                                                            
  [Composer\Downloader\TransportException]                                                                                  
  The "https://symfony.sh/r/github.com/symfony/recipes-contrib/ulid" file could not be downloaded (HTTP/1.1 404 Not Found)  
                                                                                                                            

https://asciinema.org/a/eOvkLUXo4ndZaowNeW5y6Szv0

[Nyholm]

I like this PR. We just going to make sure Travis is happy.

[Nyholm]

Travis complains here. This line should be:
Roukmoute\\HashidsBundle\\RoukmouteHashidsBundle

[ghost]

Pull request passes validation.

[ghost]

Pull request passes validation.

[roukmoute]

@Nyholm What do you want me to do?

Now the error is caused by DoctrineExtension:

To configure the ORM layer, you must first install the doctrine/orm package  

I can add in my require-dev → doctrine/orm.
Even if for me it is not to me that I add this extension.

What do you suggest?

[ghost]

Pull request passes validation.

[Nyholm]

Yeah, why do you get this error? Do you require doctrine/orm in your bundle?

[stof]

@Nyholm that's actually related to our DoctrineBundle recipe. The DoctrineBundle recipe configures the ORM layer, but the ORM is an optional dependency of DoctrineBundle, not a required one (so people wanting to use only the DBAL layer have to remove stuff after installing the recipe to get things working).

@roukmoute your dependency on DoctrineBundle alone looks weird to me though. You don't need the DBAL layer at all. Your only place depending on DoctrineBundle is for the param converter, and this will only work with the ORM enabled. So you should either have a requirement on the ORM (not only on DoctrineBundle) or make DoctrineBundle an optional dependency and disable the param converter when you don't have both DoctrineBundle and the ORM in the project.

[ghost]

Pull request passes validation.

[roukmoute]

Finally done @Nyholm!
https://travis-ci.org/symfony/recipes-contrib/jobs/348224644

[Nyholm]

Thank you. Make sure to add Symfony 4 support so all users can use this bundle

[roukmoute]

Yes it will be the next version, I will do that quickly 👍

[fabpot]

@symfony-flex-server review again

[ghost]

Pull request passes validation.