Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Add mykiwi/docker-* | Bug ? #44

Closed
wants to merge 7 commits into from

Conversation

mykiwi
Copy link

@mykiwi mykiwi commented May 27, 2017

Q A
License MIT

"copy-from-package": {
"docker-compose.yml": "/",
"docker-compose.override.yml.dist": "/",
"docker": "/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

"copy-from-package": {
"docker-compose.yml": "/",
"docker-compose.override.yml.dist": "/",
"docker": "/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

symfony-bot
symfony-bot previously approved these changes May 27, 2017
@Pierstoval
Copy link
Contributor

You must release at least one stable version for your package, else the bot refuses the PR

symfony-bot
symfony-bot previously approved these changes May 27, 2017
symfony-bot
symfony-bot previously approved these changes May 28, 2017
symfony-bot
symfony-bot previously approved these changes May 28, 2017
symfony-bot
symfony-bot previously approved these changes May 28, 2017
symfony-bot
symfony-bot previously approved these changes May 29, 2017
symfony-bot
symfony-bot previously approved these changes May 29, 2017
symfony-bot
symfony-bot previously approved these changes May 30, 2017
symfony-bot
symfony-bot previously approved these changes May 30, 2017
@vonalbert
Copy link

Just a question: does make sense to include the recipes for versions of php < 7.1 since Flex will require at least PHP 7.1.3?
I mean all the docker-symfony-php5* and docker-symfony-php70* packages

@mykiwi
Copy link
Author

mykiwi commented May 30, 2017

Good point.
Symfony 3 still works with php 5.5 so I will keep php 5.6 & 7.0; but I think I will add an other container for composer with php 7.1.

@vonalbert
Copy link

So if I'm using symfony 3.3.x (which requires php 5.5.9), as long I run all the composer commands from my host machine with php 7.1 (required only by flex ATM), everything should be fine for a development environment.

Anyway I'm not sure the dependencies could be resolved for a production env where php is 5.5, because of flex is not in required-dev section (and flex requires php 7.1).

However I cannot test it right away so I'm not 100% sure :)

@mykiwi
Copy link
Author

mykiwi commented May 31, 2017

In fact, I will remove 5.6 and 7.0 since 7.1 is in require when using flex.

@mykiwi mykiwi mentioned this pull request Jun 3, 2017
@mykiwi mykiwi changed the title (WIP) Add mykiwi/docker-* (WIP) Add mykiwi/docker-* | Bug ? Jun 3, 2017
@mykiwi mykiwi closed this Jun 3, 2017
@mykiwi mykiwi deleted the mykiwi-dockerfiles branch June 3, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants