Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for dunglas/doctrine-json-odm #507

Merged
2 commits merged into from Sep 26, 2018
Merged

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Sep 23, 2018

Q A
License MIT

https://github.com/dunglas/doctrine-json-odm
A recipe is mandatory because the bundle is provided in the library, thus cannot be auto-discovered by Flex.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@dunglas
Copy link
Member Author

dunglas commented Sep 23, 2018

Failures are intended. I tested the recipe locally and it works.

Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus one

<bg=blue;fg=white> </>

* The <comment>json_document</> column type is now available
* Go to https://github.com/dunglas/doctrine-json-odm for examples and docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this post install as it does not give any useful information the user won't already have.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now

@ghost ghost merged commit 82079d0 into symfony:master Sep 26, 2018
ghost pushed a commit that referenced this pull request Sep 26, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants