Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crayner Authenticate Bundle Recipe #644

Merged
14 commits merged into from Jun 29, 2019
Merged

Crayner Authenticate Bundle Recipe #644

14 commits merged into from Jun 29, 2019

Conversation

crayner
Copy link
Contributor

@crayner crayner commented Mar 29, 2019

Q A
License MIT

Features

  • Highest Available Encoder
  • Manage Lock on Login Failures
  • Password Validation
  • Rotate Passwords

ghost
ghost approved these changes Mar 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Mar 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Mar 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Mar 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Mar 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@crayner crayner mentioned this pull request Mar 29, 2019
Closed
Nyholm
Nyholm requested changes Apr 6, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

#eu-fossa

crayner/authenticate-bundle/1.0/config/packages/crayner_authentication.yaml Outdated Show resolved Hide resolved
ghost
ghost approved these changes Apr 7, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Nyholm
Copy link
Member

Nyholm commented Apr 9, 2019

Could you check why Travis is upset?

ghost
ghost approved these changes Apr 11, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@crayner
Copy link
Contributor Author

crayner commented Apr 11, 2019

Now passes on Symfony 4+, fails on Symfony <4, as per specification.

@maxhelias
Copy link

@crayner you can define your Configuration.php compatible like this :
https://github.com/doctrine/DoctrineBundle/blob/f5c10ecbc2e199c8deeff3aedfe3ee778d44c50a/DependencyInjection/Configuration.php#L41

And travis will be happy :)

ghost
ghost approved these changes Apr 17, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost suggested changes Apr 17, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

crayner/authenticate-bundle/1.0/config/routes/crayner_authenticate.yaml Outdated Show resolved Hide resolved
ghost
ghost approved these changes Apr 17, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Apr 17, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Apr 19, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you

@ghost ghost merged commit 0aa70d7 into symfony:master Jun 29, 2019
ghost pushed a commit that referenced this pull request Jun 29, 2019
Merge pull request #644
b6d739d
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crayner @Nyholm @maxhelias