Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmucklo/grid-bundle (5.0): Removed dependency on deprecated twig-engine #753

Merged
1 commit merged into from
Sep 29, 2019
Merged

mmucklo/grid-bundle (5.0): Removed dependency on deprecated twig-engine #753

1 commit merged into from
Sep 29, 2019

Conversation

mmucklo
Copy link
Contributor

@mmucklo mmucklo commented Sep 14, 2019

Q A
License MIT

Removes requirement on deprecated twig-engine as of mmucklo/grid-bundle 5.0

ghost
ghost approved these changes Sep 14, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@mmucklo mmucklo mentioned this pull request Sep 14, 2019
Open
Nyholm
Nyholm approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I see that this is the same as you 4.2 recipe but without the post-install.txt that encourage the user to install Twig.

ghost pushed a commit that referenced this pull request Sep 29, 2019
Merge pull request #753
cc6a17f
@ghost ghost merged commit 4575194 into symfony:master Sep 29, 2019
@mmucklo mmucklo deleted the mmucklo/grid-bundle branch March 26, 2020 04:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmucklo @Nyholm